[tool system] Circular import chain between agent_tools, tool_parsing, and tool_schemas #672

New issue

Closed

opened 2026-06-02 23:40:04 +02:00 by sleepy · 1 comment

sleepy commented

2026-06-02 23:40:04 +02:00

Owner

Circular import chain in tool modules

The tool module graph has a circular dependency chain:

agent_tools.py → tool_parsing.py → agent_tools.py (imports ToolBlock, TOOL_TAGS)
agent_tools.py → tool_schemas.py → agent_tools.py (imports ToolBlock, TOOL_TAGS)
                       tool_schemas.py → tool_parsing.py (imports _TOOL_NAME_MAP)
tool_execution.py → tool_security.py (clean)
tool_execution.py → agent_tools.py (imports get_mcp_manager via local import)
tool_implementations.py → agent_tools.py (imports get_mcp_manager via local import)

Current workaround

tool_parsing.py and tool_schemas.py import from agent_tools.py at module level
agent_tools.py imports from tool_parsing.py and tool_schemas.py at module level
This works only because Python processes the imports in a specific order, but it's fragile

Evidence

tool_parsing.py:13: from src.agent_tools import ToolBlock, TOOL_TAGS
tool_schemas.py:15: from src.agent_tools import ToolBlock, TOOL_TAGS
tool_schemas.py:16: from src.tool_parsing import _TOOL_NAME_MAP
agent_tools.py:92: from src.tool_parsing import ...
agent_tools.py:104: from src.tool_schemas import ...

Suggested fix

Move ToolBlock (a namedtuple) and TOOL_TAGS (a set) into a standalone src/tools/types.py or src/tools/constants.py
Both tool_parsing.py and tool_schemas.py import from the constants module instead of from agent_tools.py
This breaks the cycle cleanly

## Circular import chain in tool modules The tool module graph has a circular dependency chain: ``` agent_tools.py → tool_parsing.py → agent_tools.py (imports ToolBlock, TOOL_TAGS) agent_tools.py → tool_schemas.py → agent_tools.py (imports ToolBlock, TOOL_TAGS) tool_schemas.py → tool_parsing.py (imports _TOOL_NAME_MAP) tool_execution.py → tool_security.py (clean) tool_execution.py → agent_tools.py (imports get_mcp_manager via local import) tool_implementations.py → agent_tools.py (imports get_mcp_manager via local import) ``` ### Current workaround - `tool_parsing.py` and `tool_schemas.py` import from `agent_tools.py` at module level - `agent_tools.py` imports from `tool_parsing.py` and `tool_schemas.py` at module level - This works only because Python processes the imports in a specific order, but it's fragile ### Evidence - `tool_parsing.py:13`: `from src.agent_tools import ToolBlock, TOOL_TAGS` - `tool_schemas.py:15`: `from src.agent_tools import ToolBlock, TOOL_TAGS` - `tool_schemas.py:16`: `from src.tool_parsing import _TOOL_NAME_MAP` - `agent_tools.py:92`: `from src.tool_parsing import ...` - `agent_tools.py:104`: `from src.tool_schemas import ...` ### Suggested fix - Move `ToolBlock` (a `namedtuple`) and `TOOL_TAGS` (a `set`) into a standalone `src/tools/types.py` or `src/tools/constants.py` - Both `tool_parsing.py` and `tool_schemas.py` import from the constants module instead of from `agent_tools.py` - This breaks the cycle cleanly

sleepy added the

bug

enhancement

labels

2026-06-02 23:40:04 +02:00

sleepy referenced this issue from a commit

2026-06-04 03:27:50 +02:00

[tools] Break circular import chain between agent_tools/tool_parsing/tool_schemas

sleepy closed this issue

2026-06-04 03:30:05 +02:00

sleepy commented

2026-06-04 03:30:09 +02:00