[chat] ai_interaction.py at 1807 lines massively exceeds AGENTS.md ~400 line limit #722

New issue

Closed

opened 2026-06-03 00:07:08 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:07:08 +02:00

Owner

Problem

src/ai_interaction.py is 1807 lines — 4.5× the AGENTS.md ~400 line limit.

The file contains at least 8 distinct responsibilities:

Global manager singleton management (set_session_manager, get_session_manager, etc.)
Model resolution (_resolve_model)
Chat-with-model tool (do_chat_with_model)
Teacher/escalation tools (do_ask_teacher)
Second-opinion tool (do_second_opinion)
Session management tools (do_create_session, do_list_sessions, do_send_to_session, do_manage_session)
Memory management tool (do_manage_memory)
Image generation (do_generate_image)
Pipeline orchestration (do_pipeline)

AGENTS.md violations

Split files exceeding ~400 lines or containing multiple concerns
Multiple concerns co-located in a single file

Suggested fix

Split into domain-specific modules under src/ai_interaction/ or src/ai_tools/:

model_resolver.py — model resolution logic
chat_tools.py — do_chat_with_model, do_send_to_session
session_tools.py — create/list/manage session
memory_tools.py — manage_memory
pipeline_tools.py — pipeline, second_opinion
image_tools.py — generate_image
_globals.py — shared manager singletons

## Problem `src/ai_interaction.py` is 1807 lines — 4.5× the AGENTS.md ~400 line limit. The file contains at least 8 distinct responsibilities: 1. Global manager singleton management (`set_session_manager`, `get_session_manager`, etc.) 2. Model resolution (`_resolve_model`) 3. Chat-with-model tool (`do_chat_with_model`) 4. Teacher/escalation tools (`do_ask_teacher`) 5. Second-opinion tool (`do_second_opinion`) 6. Session management tools (`do_create_session`, `do_list_sessions`, `do_send_to_session`, `do_manage_session`) 7. Memory management tool (`do_manage_memory`) 8. Image generation (`do_generate_image`) 9. Pipeline orchestration (`do_pipeline`) ## AGENTS.md violations - **Split files exceeding ~400 lines or containing multiple concerns** - Multiple concerns co-located in a single file ## Suggested fix Split into domain-specific modules under `src/ai_interaction/` or `src/ai_tools/`: - `model_resolver.py` — model resolution logic - `chat_tools.py` — do_chat_with_model, do_send_to_session - `session_tools.py` — create/list/manage session - `memory_tools.py` — manage_memory - `pipeline_tools.py` — pipeline, second_opinion - `image_tools.py` — generate_image - `_globals.py` — shared manager singletons

sleepy added the

refactor

area:llm

labels

2026-06-04 10:07:34 +02:00

sleepy referenced this issue from a commit

2026-06-04 11:52:59 +02:00

refactor: split ai_interaction.py (1849 lines) into src/ai_interaction/ (#722)

sleepy closed this issue

2026-06-04 11:53:11 +02:00

sleepy referenced this issue from a commit

2026-06-04 11:53:11 +02:00