[chat] builtin_actions.py at 2194 lines massively exceeds AGENTS.md ~400 line limit #723

New issue

Closed

opened 2026-06-03 00:07:25 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:07:25 +02:00

Owner

Problem

src/builtin_actions.py is 2194 lines — 5.5× the AGENTS.md ~400 line limit.

The file is a registry of unrelated scheduled actions, each completely independent:

action_tidy_sessions — session cleanup
action_tidy_documents — document cleanup
action_consolidate_memory — memory dedup (~170 lines alone)
SSH/script execution actions
action_tidy_research — research file cleanup
action_tidy_calendar — calendar dedup (~100 lines)
action_summarize_emails / action_draft_email_replies — email processing
action_classify_events — LLM-based calendar event classification (~160 lines)
action_mark_email_boundaries — email boundary detection (~200 lines)
action_learn_sender_signatures — sender signature learning (~200+ lines)
More actions beyond line 1000 (truncated)

AGENTS.md violations

Split files exceeding ~400 lines or containing multiple concerns
Each action is a separate domain concern that should live in its own module

Suggested fix

Move each action to its own module under src/builtin_actions/ or src/actions/:

tidy_sessions.py, tidy_documents.py, tidy_calendar.py, tidy_research.py
memory_consolidate.py
ssh_command.py, run_script.py
email_actions.py (summarize, draft, boundaries, signatures)
calendar_classify.py
Keep builtin_actions.py as a thin registry that imports and re-exports

## Problem `src/builtin_actions.py` is 2194 lines — 5.5× the AGENTS.md ~400 line limit. The file is a registry of unrelated scheduled actions, each completely independent: 1. `action_tidy_sessions` — session cleanup 2. `action_tidy_documents` — document cleanup 3. `action_consolidate_memory` — memory dedup (~170 lines alone) 4. SSH/script execution actions 5. `action_tidy_research` — research file cleanup 6. `action_tidy_calendar` — calendar dedup (~100 lines) 7. `action_summarize_emails` / `action_draft_email_replies` — email processing 8. `action_classify_events` — LLM-based calendar event classification (~160 lines) 9. `action_mark_email_boundaries` — email boundary detection (~200 lines) 10. `action_learn_sender_signatures` — sender signature learning (~200+ lines) 11. More actions beyond line 1000 (truncated) ## AGENTS.md violations - **Split files exceeding ~400 lines or containing multiple concerns** - Each action is a separate domain concern that should live in its own module ## Suggested fix Move each action to its own module under `src/builtin_actions/` or `src/actions/`: - `tidy_sessions.py`, `tidy_documents.py`, `tidy_calendar.py`, `tidy_research.py` - `memory_consolidate.py` - `ssh_command.py`, `run_script.py` - `email_actions.py` (summarize, draft, boundaries, signatures) - `calendar_classify.py` - Keep `builtin_actions.py` as a thin registry that imports and re-exports

sleepy added the

refactor

area:llm

labels

2026-06-04 10:07:34 +02:00

sleepy referenced this issue from a commit

2026-06-04 11:38:10 +02:00

refactor: split builtin_actions.py (2237 lines) into src/builtin_actions/ (#723)

sleepy referenced this issue from a pull request that will close it,

2026-06-04 11:39:05 +02:00

[llm] Split builtin_actions.py (2237→8 line facade) into src/builtin_actions/ (#723) #925

sleepy closed this issue