[chat] builtin_actions.py uses raw SQLite while project uses SQLAlchemy ORM #732

New issue

Closed

opened 2026-06-03 00:09:28 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:09:28 +02:00

Owner

Problem

src/builtin_actions.py uses raw sqlite3 connections and SQL strings in multiple places:

Line 787-791: sqlite3.connect(SCHEDULED_DB) with raw SELECT message_id FROM email_boundaries
Line 899-907: Raw INSERT OR REPLACE INTO email_boundaries via c.execute()
Line 997-999: Raw SELECT from_address, last_built_at FROM sender_signatures
Line 1108: Raw SQL execution
Lines 1946-1976: Raw SQLite operations

The project uses SQLAlchemy ORM throughout (core/database.py defines all models). The SCHEDULED_DB is a separate SQLite database, but even so, using raw SQL when the project has an ORM pattern is a violation.

AGENTS.md violations

No raw SQL when project uses an ORM

Suggested fix

Define SQLAlchemy models for email_boundaries and sender_signatures tables
Use the standard SessionLocal() pattern for database access
If SCHEDULED_DB must remain separate, at minimum use parameterized queries consistently and wrap in a repository pattern

## Problem `src/builtin_actions.py` uses raw `sqlite3` connections and SQL strings in multiple places: - Line 787-791: `sqlite3.connect(SCHEDULED_DB)` with raw `SELECT message_id FROM email_boundaries` - Line 899-907: Raw `INSERT OR REPLACE INTO email_boundaries` via `c.execute()` - Line 997-999: Raw `SELECT from_address, last_built_at FROM sender_signatures` - Line 1108: Raw SQL execution - Lines 1946-1976: Raw SQLite operations The project uses SQLAlchemy ORM throughout (`core/database.py` defines all models). The `SCHEDULED_DB` is a separate SQLite database, but even so, using raw SQL when the project has an ORM pattern is a violation. ## AGENTS.md violations - **No raw SQL when project uses an ORM** ## Suggested fix 1. Define SQLAlchemy models for `email_boundaries` and `sender_signatures` tables 2. Use the standard `SessionLocal()` pattern for database access 3. If `SCHEDULED_DB` must remain separate, at minimum use parameterized queries consistently and wrap in a repository pattern

sleepy referenced this issue from a commit

2026-06-03 20:05:18 +02:00

[actions] Replace raw SQLite with SQLAlchemy ORM (#732)

sleepy referenced this issue from a pull request that will close it,

2026-06-03 20:07:37 +02:00

[actions] Replace raw SQLite with SQLAlchemy ORM (#732) #833

sleepy closed this issue

2026-06-03 20:07:45 +02:00