[memory/RAG] Dead code: src/memory.py is a near-duplicate of services/memory/memory.py #746

New issue

Closed

opened 2026-06-03 00:17:46 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:17:46 +02:00

Owner

Legacy duplication: src/memory.py (365 lines) and services/memory/memory.py (359 lines) are nearly identical files containing the same MemoryManager class, tokenize(), and get_text_similarity().

Key differences:

src/memory.py has increment_uses() and uses field in _validate_entries / add_entry — these are present in the active services/memory/memory.py copy too
services/memory/memory.py is imported by services/memory/__init__.py and is the active module
src/memory.py appears to be the pre-refactor original that was copied into services/

Action: Verify src/memory.py has no active importers, then delete it. The same applies to src/memory_vector.py which is identical to services/memory/memory_vector.py (both 175 lines, same MemoryVectorStore class).

**Legacy duplication**: `src/memory.py` (365 lines) and `services/memory/memory.py` (359 lines) are nearly identical files containing the same `MemoryManager` class, `tokenize()`, and `get_text_similarity()`. **Key differences**: - `src/memory.py` has `increment_uses()` and `uses` field in `_validate_entries` / `add_entry` — these are present in the active `services/memory/memory.py` copy too - `services/memory/memory.py` is imported by `services/memory/__init__.py` and is the active module - `src/memory.py` appears to be the pre-refactor original that was copied into `services/` **Action**: Verify `src/memory.py` has no active importers, then delete it. The same applies to `src/memory_vector.py` which is identical to `services/memory/memory_vector.py` (both 175 lines, same `MemoryVectorStore` class).

sleepy referenced this issue from a commit

2026-06-03 15:36:37 +02:00

fix: remove dead code src/memory.py and src/memory_vector.py (#746)

sleepy referenced this issue from a pull request that will close it,

2026-06-03 15:37:15 +02:00

fix: remove dead code src/memory.py and src/memory_vector.py #799

sleepy closed this issue

2026-06-03 15:37:20 +02:00