[memory/RAG] Dead code: src/rag_manager.py is a zero-value wrapper that just delegates to VectorRAG #747

New issue

Closed

opened 2026-06-03 00:17:58 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:17:58 +02:00

Owner

File: src/rag_manager.py — 59 lines

RAGManager is a pure delegation class where every method (search, retrieve, rebuild_index, get_stats, add_document, add_documents_batch, index_personal_documents) does nothing but call self.vector_rag.<same_method>().

It also has a fragile triple-import fallback chain:

try:
    from rag_vector import VectorRAG
except ImportError:
    try:
        from .rag_vector import VectorRAG
    except ImportError:
        from src.rag_vector import VectorRAG

This wrapper adds no logic, no caching, no transformation — just an extra indirection layer. All callers could import VectorRAG directly.

Action: Audit all callers of RAGManager and replace with direct VectorRAG usage, then delete src/rag_manager.py.

**File**: `src/rag_manager.py` — 59 lines `RAGManager` is a pure delegation class where every method (`search`, `retrieve`, `rebuild_index`, `get_stats`, `add_document`, `add_documents_batch`, `index_personal_documents`) does nothing but call `self.vector_rag.<same_method>()`. It also has a fragile triple-import fallback chain: ```python try: from rag_vector import VectorRAG except ImportError: try: from .rag_vector import VectorRAG except ImportError: from src.rag_vector import VectorRAG ``` This wrapper adds no logic, no caching, no transformation — just an extra indirection layer. All callers could import `VectorRAG` directly. **Action**: Audit all callers of `RAGManager` and replace with direct `VectorRAG` usage, then delete `src/rag_manager.py`.

sleepy referenced this issue from a commit

2026-06-03 15:31:46 +02:00

fix: remove dead code src/rag_manager.py (#747)

sleepy closed this issue

2026-06-03 15:31:50 +02:00

sleepy referenced this issue from a pull request that will close it,

2026-06-03 15:32:13 +02:00

fix: remove dead code src/rag_manager.py (#747) #798