[memory] Duplicated entry validation logic in _validate_entries() and save() #759

New issue

Closed

opened 2026-06-03 00:20:57 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:20:57 +02:00

Owner

"File: services/memory/memory.py _validate_entries() (line 142) and save() (line 184) both do the same field-defaulting logic: python if "id" not in entry: entry["id"] = str(uuid.uuid4()) if "timestamp" not in entry: entry["timestamp"] = int(time.time()) if "source" not in entry: entry["source"] = "..." if "category" not in entry: entry["category"] = "fact" This validation runs on every load_all() AND every save(). For a list of N entries, that's 2N validation passes per write cycle. The save() path should trust that _validate_entries already ran during load, or the validation should be a single method called once. Additionally, _validate_entries mutates the input list in place AND returns it — confusing contract."

"**File**: `services/memory/memory.py` `_validate_entries()` (line 142) and `save()` (line 184) both do the same field-defaulting logic: ```python if "id" not in entry: entry["id"] = str(uuid.uuid4()) if "timestamp" not in entry: entry["timestamp"] = int(time.time()) if "source" not in entry: entry["source"] = "..." if "category" not in entry: entry["category"] = "fact" ``` This validation runs on every `load_all()` AND every `save()`. For a list of N entries, that's 2N validation passes per write cycle. The `save()` path should trust that `_validate_entries` already ran during load, or the validation should be a single method called once. Additionally, `_validate_entries` mutates the input list in place AND returns it — confusing contract."

sleepy referenced this issue from a commit

2026-06-03 16:21:33 +02:00

fix(#759): deduplicate entry validation in MemoryManager

sleepy referenced this issue from a pull request that will close it,

2026-06-03 16:21:47 +02:00

fix(#759): Deduplicate entry validation in MemoryManager #806

sleepy closed this issue

2026-06-03 16:22:04 +02:00