[search] Duplicate search implementation in services/search/ and src/search/ — near-identical files #771

New issue

Closed

opened 2026-06-03 00:28:08 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:28:08 +02:00

Owner

Problem

Two nearly-identical copies of the search module exist:

services/search/ (8 files, ~2240 lines)
src/search/ (7 files, ~2183 lines)

Only minor differences exist between them (e.g., content.py has 160 lines of diff, providers.py has 27 lines of diff for comment rewording). services/search/ has an extra service.py that src/search/ lacks.

Cross-import inconsistency

Routes import from services.search:

routes/search_routes.py → from services.search import ...

But src/deep_research.py imports from src.search:

from src.search.providers import _get_search_settings
from src.search.core import _call_provider, _build_provider_chain

This means two different copies of the same code are being used depending on call path.

AGENTS.md violations

No duplication: Two copies of the same codebase violates the principle of organizing by feature/domain
No README.md in either services/search/ or src/search/

Fix

Pick one canonical location (likely services/search/ since routes use it)
Delete the duplicate src/search/ or make it a thin re-export
Update src/deep_research.py imports
Add README.md

## Problem Two nearly-identical copies of the search module exist: - `services/search/` (8 files, ~2240 lines) - `src/search/` (7 files, ~2183 lines) Only minor differences exist between them (e.g., `content.py` has 160 lines of diff, `providers.py` has 27 lines of diff for comment rewording). `services/search/` has an extra `service.py` that `src/search/` lacks. ## Cross-import inconsistency Routes import from `services.search`: - `routes/search_routes.py` → `from services.search import ...` But `src/deep_research.py` imports from `src.search`: - `from src.search.providers import _get_search_settings` - `from src.search.core import _call_provider, _build_provider_chain` This means two different copies of the same code are being used depending on call path. ## AGENTS.md violations - **No duplication**: Two copies of the same codebase violates the principle of organizing by feature/domain - **No README.md** in either `services/search/` or `src/search/` ## Fix 1. Pick one canonical location (likely `services/search/` since routes use it) 2. Delete the duplicate `src/search/` or make it a thin re-export 3. Update `src/deep_research.py` imports 4. Add `README.md`

sleepy referenced this issue

2026-06-03 00:29:47 +02:00

[search/research/infrastructure] Missing README.md in services/search/, src/search/, services/research/ — violates AGENTS.md feature directory requirement #782

sleepy referenced this issue

2026-06-03 00:32:14 +02:00

[search] content.py diverges significantly between services/search/ and src/search/ — security risk #784

sleepy referenced this issue from a commit

2026-06-03 22:24:42 +02:00

[search] Reconcile duplicate search implementations (#771)

sleepy referenced this issue from a pull request that will close it,

2026-06-03 22:25:14 +02:00

[search] Reconcile duplicate search implementations (#771) #856