[infrastructure] task_scheduler.py at 2174 lines massively exceeds AGENTS.md ~400 line limit #774

New issue

Closed

opened 2026-06-03 00:28:40 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:28:40 +02:00

Owner

Problem

src/task_scheduler.py is 2174 lines with a single TaskScheduler class containing 40+ methods spanning:

TTL cache / singleflight logic
Schedule computation and timezone handling
Task execution engine with model slot management
Notification system
Email delivery
MCP tool execution
Agent loop execution
Research task execution
Task chaining with cycle detection
Miniflux RSS integration
Default task resolution
Health check / ping loops

Plus ~15 standalone helper functions.

AGENTS.md violation

Split files that exceed ~400 lines or contain multiple concerns.

This is the largest single file in the codebase and contains at least 8 distinct concerns.

Suggested split

scheduler/cache.py — shared TTL cache
scheduler/timing.py — schedule computation, timezone resolution
scheduler/executor.py — core task execution loop
scheduler/notifications.py — notification management
scheduler/delivery.py — email, MCP, session delivery
scheduler/actions/ — individual action handlers (LLM, check-in, research, agent loop)
scheduler/defaults.py — default task resolution
scheduler/README.md

## Problem `src/task_scheduler.py` is 2174 lines with a single `TaskScheduler` class containing 40+ methods spanning: - TTL cache / singleflight logic - Schedule computation and timezone handling - Task execution engine with model slot management - Notification system - Email delivery - MCP tool execution - Agent loop execution - Research task execution - Task chaining with cycle detection - Miniflux RSS integration - Default task resolution - Health check / ping loops Plus ~15 standalone helper functions. ## AGENTS.md violation > Split files that exceed ~400 lines or contain multiple concerns. This is the largest single file in the codebase and contains at least 8 distinct concerns. ## Suggested split - `scheduler/cache.py` — shared TTL cache - `scheduler/timing.py` — schedule computation, timezone resolution - `scheduler/executor.py` — core task execution loop - `scheduler/notifications.py` — notification management - `scheduler/delivery.py` — email, MCP, session delivery - `scheduler/actions/` — individual action handlers (LLM, check-in, research, agent loop) - `scheduler/defaults.py` — default task resolution - `scheduler/README.md`

sleepy added the

refactor

area:core

labels

2026-06-04 10:07:36 +02:00

sleepy referenced this issue from a commit

2026-06-04 11:23:44 +02:00

refactor: split task_scheduler.py (2174 lines) into src/task_scheduler/ (#774)

sleepy referenced this issue from a pull request that will close it,

2026-06-04 11:24:08 +02:00

[core] Split task_scheduler.py (2174→2 line facade) into src/task_scheduler/ (#774) #920

sleepy referenced this issue from a commit