[routes] skills_routes.py at 1530 lines exceeds AGENTS.md ~400 line limit #777

New issue

Closed

opened 2026-06-03 00:29:18 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:29:18 +02:00

Owner

Problem

routes/skills_routes.py is 1530 lines with 51 function definitions mixing:

REST API route handlers (CRUD for skills)
Skill evaluation/testing engine
Skill audit system with LLM-based quality checks
Skill improvement/suggestion generation
Auto-publish policy management
Duplicate detection
Scheduled audit job runner

Many of the 51 functions are nested inside setup_skills_routes() making them hard to test independently.

AGENTS.md violation

Split files that exceed ~400 lines or contain multiple concerns.

Suggested split

routes/skills/crud.py — basic skill CRUD routes
routes/skills/audit.py — audit and quality evaluation
routes/skills/testing.py — skill test execution
routes/skills/improvement.py — skill improvement suggestions
Or move business logic into services/skills/ and keep routes thin

## Problem `routes/skills_routes.py` is 1530 lines with 51 function definitions mixing: - REST API route handlers (CRUD for skills) - Skill evaluation/testing engine - Skill audit system with LLM-based quality checks - Skill improvement/suggestion generation - Auto-publish policy management - Duplicate detection - Scheduled audit job runner Many of the 51 functions are nested inside `setup_skills_routes()` making them hard to test independently. ## AGENTS.md violation > Split files that exceed ~400 lines or contain multiple concerns. ## Suggested split - `routes/skills/crud.py` — basic skill CRUD routes - `routes/skills/audit.py` — audit and quality evaluation - `routes/skills/testing.py` — skill test execution - `routes/skills/improvement.py` — skill improvement suggestions - Or move business logic into `services/skills/` and keep routes thin

sleepy added the

refactor

area:routes

labels

2026-06-04 10:07:35 +02:00

sleepy referenced this issue from a commit

2026-06-04 12:07:28 +02:00

refactor: split skills_routes.py into routes/skills_routes/ (#777)

sleepy closed this issue

2026-06-04 12:07:49 +02:00

sleepy referenced this issue from a commit

2026-06-04 12:07:50 +02:00