[routes] task_routes.py (1000 lines), shell_routes.py (936 lines), history_routes.py (619 lines), research_routes.py (611 lines), mcp_routes.py (579 lines) all exceed AGENTS.md ~400 line limit #779

New issue

Closed

opened 2026-06-03 00:29:22 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:29:22 +02:00

Owner

Problem

Multiple route files exceed the ~400 line guideline:

File	Lines	Functions
`routes/task_routes.py`	1000	31
`routes/shell_routes.py`	936	28
`routes/history_routes.py`	619	13
`routes/research_routes.py`	611	23
`routes/mcp_routes.py`	579	16

Specific concerns

shell_routes.py mixes PTY streaming, tmux session management, Windows detached mode, SSH remote execution, and package management — 5 distinct concerns in one file
task_routes.py mixes task CRUD, task scheduling UI, scheduled task management, and cross-imports from routes/prefs_routes.py and routes/email_helpers
research_routes.py imports services/research/ but the deep research flow has inline logic

AGENTS.md violation

Split files that exceed ~400 lines or contain multiple concerns.

Cross-route coupling

routes/history_routes.py imports from routes.session_routes import _verify_session_owner — private function across routes
routes/task_routes.py imports from routes.prefs_routes import _load_for_user, _save_for_user
routes/cookbook_routes.py imports from routes.shell_routes import TMUX_LOG_DIR
routes/skills_routes.py has from routes.prefs_routes import _load_for_user

## Problem Multiple route files exceed the ~400 line guideline: | File | Lines | Functions | |------|-------|------------| | `routes/task_routes.py` | 1000 | 31 | | `routes/shell_routes.py` | 936 | 28 | | `routes/history_routes.py` | 619 | 13 | | `routes/research_routes.py` | 611 | 23 | | `routes/mcp_routes.py` | 579 | 16 | ## Specific concerns - `shell_routes.py` mixes PTY streaming, tmux session management, Windows detached mode, SSH remote execution, and package management — 5 distinct concerns in one file - `task_routes.py` mixes task CRUD, task scheduling UI, scheduled task management, and cross-imports from `routes/prefs_routes.py` and `routes/email_helpers` - `research_routes.py` imports `services/research/` but the deep research flow has inline logic ## AGENTS.md violation > Split files that exceed ~400 lines or contain multiple concerns. ## Cross-route coupling - `routes/history_routes.py` imports `from routes.session_routes import _verify_session_owner` — private function across routes - `routes/task_routes.py` imports `from routes.prefs_routes import _load_for_user, _save_for_user` - `routes/cookbook_routes.py` imports `from routes.shell_routes import TMUX_LOG_DIR` - `routes/skills_routes.py` has `from routes.prefs_routes import _load_for_user`

sleepy added the

refactor

area:routes

labels

2026-06-04 10:07:35 +02:00

sleepy referenced this issue from a commit

2026-06-04 13:10:31 +02:00

refactor: split task/shell/history/research/mcp routes into route packages (#779)

sleepy closed this issue

2026-06-04 13:10:54 +02:00

sleepy referenced this issue from a commit

2026-06-04 13:10:54 +02:00