sleepy/odysseus
1
0
Fork
You've already forked odysseus
 0
Code Issues 9 Pull requests 10 Projects Releases Packages Wiki Activity Actions

[security] Fix tool_security fail-closed on auth errors #893

Closed
sleepy wants to merge 0 commits from fix/tool-security-fail-safe-675 into dev
pull from: fix/tool-security-fail-safe-675
merge into: sleepy:dev
Conversation 0 Commits - Files changed -
sleepy commented 2026-06-04 02:18:52 +02:00
Owner
Copy link
No description provided. 
When tool_security.py encountered auth errors (DB unavailable, corrupt
auth store), owner_is_admin_or_single_user() returned False for all
users including admins. This caused blocked_tools_for_owner() to
return the full blocked set, locking out admins during auth degradation.

Fix: fail-open for identified users (any owner with a username) and
fail-closed only when identity is unknown (no owner). Add error-level
logging for auth failures so they're visible in monitoring.
sleepy closed this pull request 2026-06-04 02:20:03 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area:chat

   
area:core

   
area:llm

   
area:routes

   
area:tools

   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor

   
wontfix
This will not be worked on

No labels
area:chat
area:core
area:llm
area:routes
area:tools
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sleepy/odysseus!893
No description provided.