cleanup: Remove profiling prints before merge #44

New issue

Closed

opened 2026-05-15 19:02:26 +02:00 by sleepy · 1 comment

sleepy commented

2026-05-15 19:02:26 +02:00

Owner

The decode timing instrumentation in engine.zig and model.zig should be removed or made conditional before merging to master:

engine.zig: "Decode: X tokens in Ys = Z tok/s" — keep this one (useful for CLI)
model.zig: "decode_profile: gpu=Xms readback+argmax=Yms" — remove or gate behind debug flag
Both use std.c.mach_absolute_time() and std.c.mach_timebase_info which are macOS-specific

The decode timing instrumentation in engine.zig and model.zig should be removed or made conditional before merging to master: - `engine.zig`: "Decode: X tokens in Ys = Z tok/s" — keep this one (useful for CLI) - `model.zig`: "decode_profile: gpu=Xms readback+argmax=Yms" — remove or gate behind debug flag - Both use `std.c.mach_absolute_time()` and `std.c.mach_timebase_info` which are macOS-specific

sleepy added the

refactor

label

2026-05-20 19:53:47 +02:00

sleepy referenced this issue from a commit

2026-05-20 20:01:15 +02:00

refactor(#44): gate profiling prints behind debug flag, keep CLI decode timing

sleepy referenced this issue

2026-05-20 20:02:01 +02:00

[cleanup] Gate profiling prints behind debug flag (#44) #54

sleepy referenced this issue from a commit

2026-05-20 20:09:54 +02:00

refactor(#44): gate profiling prints behind debug flag, keep CLI decode timing

sleepy referenced this issue from a commit

2026-05-20 20:10:43 +02:00

[cleanup] Gate profiling prints behind debug flag (#44) (#54)

sleepy referenced this issue from a commit

2026-05-20 20:11:02 +02:00

refactor(#44): gate profiling prints behind debug flag, keep CLI decode timing

sleepy closed this issue

2026-05-20 20:11:02 +02:00

sleepy commented

2026-05-20 20:11:22 +02:00

Author

Owner

Merged via squash. Profiling prints gated behind @import("builtin").mode == .Debug.

decode_profile and argmax_compare prints only appear in debug builds
GPU argmax dispatch moved inside debug block (no dead work in release)
Shared readback and CPU argmax logic kept single-path
CLI decode timing in engine.zig preserved

Merged via squash. Profiling prints gated behind `@import("builtin").mode == .Debug`. - `decode_profile` and `argmax_compare` prints only appear in debug builds - GPU argmax dispatch moved inside debug block (no dead work in release) - Shared readback and CPU argmax logic kept single-path - CLI decode timing in engine.zig preserved