[cross-feature coupling] model_routes imports 6 private functions from llm_core internals #703

New issue

Closed

opened 2026-06-02 23:56:00 +02:00 by sleepy · 1 comment

sleepy commented

2026-06-02 23:56:00 +02:00

Owner

AGENTS.md rule: Features communicate through narrow, typed interfaces. Never import another feature's internals directly.

routes/model_routes.py directly imports private internals from src.llm_core:

from src.llm_core import _detect_provider, ANTHROPIC_MODELS       # line 17
from src.llm_core import _normalize_anthropic_url, _build_anthropic_headers, _build_anthropic_payload  # line 228
from src.llm_core import _build_ollama_payload                     # line 236
from src.llm_core import _uses_max_completion_tokens               # line 245

These are all underscore-prefixed (private) functions. model_routes.py should call through the public API (llm_call, llm_call_async, stream_llm) or the public functions in endpoint_resolver.py.

Additionally, model_routes.py re-implements 4 helper functions that already exist in llm_core.py and endpoint_resolver.py:

_anthropic_api_root (line 25) — duplicate of endpoint_resolver._anthropic_api_root (line 110) and llm_core._anthropic_api_root concept
_ollama_api_root (line 34) — duplicate of endpoint_resolver._ollama_api_root (line 119)
_provider_headers (line 59) — duplicate of endpoint_resolver.build_headers (line 157) and llm_core._provider_headers (line 229)
_models_url (line 48) — duplicate of endpoint_resolver.build_models_url (line 145)

Fix: Remove duplicated helpers from model_routes.py and import the public versions from endpoint_resolver.py. Expose any needed internal functions through a proper public interface in llm_core.

**AGENTS.md rule:** Features communicate through narrow, typed interfaces. Never import another feature's internals directly. `routes/model_routes.py` directly imports private internals from `src.llm_core`: ```python from src.llm_core import _detect_provider, ANTHROPIC_MODELS # line 17 from src.llm_core import _normalize_anthropic_url, _build_anthropic_headers, _build_anthropic_payload # line 228 from src.llm_core import _build_ollama_payload # line 236 from src.llm_core import _uses_max_completion_tokens # line 245 ``` These are all underscore-prefixed (private) functions. `model_routes.py` should call through the public API (`llm_call`, `llm_call_async`, `stream_llm`) or the public functions in `endpoint_resolver.py`. Additionally, `model_routes.py` re-implements 4 helper functions that already exist in `llm_core.py` and `endpoint_resolver.py`: - `_anthropic_api_root` (line 25) — duplicate of `endpoint_resolver._anthropic_api_root` (line 110) and `llm_core._anthropic_api_root` concept - `_ollama_api_root` (line 34) — duplicate of `endpoint_resolver._ollama_api_root` (line 119) - `_provider_headers` (line 59) — duplicate of `endpoint_resolver.build_headers` (line 157) and `llm_core._provider_headers` (line 229) - `_models_url` (line 48) — duplicate of `endpoint_resolver.build_models_url` (line 145) **Fix:** Remove duplicated helpers from `model_routes.py` and import the public versions from `endpoint_resolver.py`. Expose any needed internal functions through a proper public interface in `llm_core`.

sleepy referenced this issue

2026-06-03 00:09:02 +02:00

[chat] ai_interaction.py imports private _detect_provider and ANTHROPIC_MODELS from llm_core internals #730

sleepy referenced this issue from a commit

2026-06-04 00:27:23 +02:00

[llm_core] Eliminate private-import coupling from model_routes and endpoint_resolver (#704, #703)

sleepy closed this issue

2026-06-04 00:29:06 +02:00

sleepy commented

2026-06-04 00:29:14 +02:00

Author

Owner