[chat] ai_interaction.py imports private _detect_provider and ANTHROPIC_MODELS from llm_core internals #730

New issue

Closed

opened 2026-06-03 00:09:02 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:09:02 +02:00

Owner

Problem

src/ai_interaction.py lines 72 and 1097 import:

from src.llm_core import _detect_provider, ANTHROPIC_MODELS

_detect_provider is a private function (underscore-prefixed) belonging to llm_core. ANTHROPIC_MODELS is an internal constant. This is cross-feature coupling through internals.

This same issue was flagged for endpoint_resolver and model_routes (#704, #703).

AGENTS.md violations

Features communicate through narrow, typed interfaces — never import another feature's internals directly
No cross-feature dependencies without explicit interfaces

Suggested fix

If _detect_provider is needed by multiple modules, promote it to a public function in a shared utility (e.g., src/provider_detection.py)
If ANTHROPIC_MODELS is a shared constant, move it to a constants module
Provide a public resolve_model function in llm_core or endpoint_resolver that encapsulates provider detection internally

## Problem `src/ai_interaction.py` lines 72 and 1097 import: ```python from src.llm_core import _detect_provider, ANTHROPIC_MODELS ``` `_detect_provider` is a private function (underscore-prefixed) belonging to llm_core. `ANTHROPIC_MODELS` is an internal constant. This is cross-feature coupling through internals. This same issue was flagged for endpoint_resolver and model_routes (#704, #703). ## AGENTS.md violations - **Features communicate through narrow, typed interfaces — never import another feature's internals directly** - **No cross-feature dependencies without explicit interfaces** ## Suggested fix 1. If `_detect_provider` is needed by multiple modules, promote it to a public function in a shared utility (e.g., `src/provider_detection.py`) 2. If `ANTHROPIC_MODELS` is a shared constant, move it to a constants module 3. Provide a public `resolve_model` function in llm_core or endpoint_resolver that encapsulates provider detection internally

sleepy referenced this issue from a commit

2026-06-03 21:08:42 +02:00

[llm] Promote _detect_provider to public detect_provider (closes #730)

sleepy referenced this issue from a pull request that will close it,

2026-06-03 21:08:50 +02:00

[llm] Promote private llm_core exports to public API (#730) #846

sleepy closed this issue

2026-06-03 21:08:57 +02:00