[cross-feature coupling] endpoint_resolver imports private _detect_provider from llm_core #704

New issue

Closed

opened 2026-06-02 23:56:16 +02:00 by sleepy · 1 comment

sleepy commented

2026-06-02 23:56:16 +02:00

Owner

File: src/endpoint_resolver.py line 15

AGENTS.md rule: Features communicate through narrow, typed interfaces. Never import another feature's internals directly.

from src.llm_core import _detect_provider

endpoint_resolver imports _detect_provider — a private, underscore-prefixed function. This creates a tight coupling between two core modules. If llm_core is refactored (see issue #700), this import breaks.

Provider detection is used by both endpoint_resolver.py and model_routes.py and should either:

Be promoted to a proper public function in llm_core (remove underscore prefix), or
Be extracted to a shared src/llm_core/providers.py module that both can import from.

This is part of the broader duplication problem: _detect_provider is called in llm_core.py, endpoint_resolver.py, model_routes.py, and ai_interaction.py.

**File:** `src/endpoint_resolver.py` line 15 **AGENTS.md rule:** Features communicate through narrow, typed interfaces. Never import another feature's internals directly. ```python from src.llm_core import _detect_provider ``` `endpoint_resolver` imports `_detect_provider` — a private, underscore-prefixed function. This creates a tight coupling between two core modules. If `llm_core` is refactored (see issue #700), this import breaks. Provider detection is used by both `endpoint_resolver.py` and `model_routes.py` and should either: 1. Be promoted to a proper public function in `llm_core` (remove underscore prefix), or 2. Be extracted to a shared `src/llm_core/providers.py` module that both can import from. This is part of the broader duplication problem: `_detect_provider` is called in `llm_core.py`, `endpoint_resolver.py`, `model_routes.py`, and `ai_interaction.py`.

sleepy referenced this issue

2026-06-03 00:09:02 +02:00

[chat] ai_interaction.py imports private _detect_provider and ANTHROPIC_MODELS from llm_core internals #730

sleepy referenced this issue from a commit

2026-06-04 00:27:23 +02:00

[llm_core] Eliminate private-import coupling from model_routes and endpoint_resolver (#704, #703)

sleepy closed this issue

2026-06-04 00:29:05 +02:00

sleepy commented

2026-06-04 00:29:12 +02:00

Author

Owner