[search] Cross-feature coupling: routes import private functions from services.search internals #776

New issue

Closed

opened 2026-06-03 00:28:51 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:28:51 +02:00

Owner

Problem

routes/search_routes.py imports private (underscore-prefixed) functions directly from module internals:

from services.search.core import _call_provider
from services.search.providers import _get_provider_key, _get_search_instance

And src/deep_research.py does the same from the other copy:

from src.search.providers import _get_search_settings
from src.search.core import _call_provider, _build_provider_chain

AGENTS.md violation

Features communicate through narrow, typed interfaces. Never import another feature's internals directly.

Fix

Expose public functions in services/search/__init__.py (or a service.py facade)
Remove all private imports from routes and other features
The existing services/search/service.py (95 lines) may already be intended for this but is not used

## Problem `routes/search_routes.py` imports private (underscore-prefixed) functions directly from module internals: ``` from services.search.core import _call_provider from services.search.providers import _get_provider_key, _get_search_instance ``` And `src/deep_research.py` does the same from the other copy: ``` from src.search.providers import _get_search_settings from src.search.core import _call_provider, _build_provider_chain ``` ## AGENTS.md violation > Features communicate through narrow, typed interfaces. Never import another feature's internals directly. ## Fix 1. Expose public functions in `services/search/__init__.py` (or a `service.py` facade) 2. Remove all private imports from routes and other features 3. The existing `services/search/service.py` (95 lines) may already be intended for this but is not used

sleepy referenced this issue

2026-06-03 00:30:06 +02:00

[search] services/search/service.py exists but is unused — routes import internals instead #783

sleepy referenced this issue from a commit

2026-06-03 22:01:22 +02:00

[search] Eliminate cross-feature coupling from routes (#776)

sleepy referenced this issue from a pull request that will close it,

2026-06-03 22:01:30 +02:00

[search] Eliminate cross-feature coupling from routes (#776) #853

sleepy closed this issue

2026-06-03 22:01:36 +02:00