[search] services/search/service.py exists but is unused — routes import internals instead #783

New issue

Closed

opened 2026-06-03 00:30:06 +02:00 by sleepy · 0 comments

sleepy commented

2026-06-03 00:30:06 +02:00

Owner

Problem

services/search/service.py (95 lines) appears to be intended as the public facade for the search feature, but:

routes/search_routes.py bypasses it entirely, importing directly from services.search.core and services.search.providers
src/deep_research.py imports from src.search.* (the duplicate copy)
No other file imports from services.search.service

AGENTS.md violation

This is related to the cross-feature coupling issue (#776) — the public interface layer exists but is not used.

Fix

Ensure service.py re-exports all public API functions
Update all consumers to import from service.py or __init__.py
Remove private function imports from routes

## Problem `services/search/service.py` (95 lines) appears to be intended as the public facade for the search feature, but: 1. `routes/search_routes.py` bypasses it entirely, importing directly from `services.search.core` and `services.search.providers` 2. `src/deep_research.py` imports from `src.search.*` (the duplicate copy) 3. No other file imports from `services.search.service` ## AGENTS.md violation This is related to the cross-feature coupling issue (#776) — the public interface layer exists but is not used. ## Fix 1. Ensure `service.py` re-exports all public API functions 2. Update all consumers to import from `service.py` or `__init__.py` 3. Remove private function imports from routes

sleepy referenced this issue from a commit

2026-06-03 15:41:01 +02:00

fix(search): make service.py the proper public facade

sleepy referenced this issue from a pull request that will close it,

2026-06-03 15:41:19 +02:00

fix(search): make service.py the proper public facade (#783) #800

sleepy closed this issue

2026-06-03 15:41:24 +02:00